Simplify alignment check in get_observations_and_responses

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

98 stars 104 forks source link

Simplify alignment check in get_observations_and_responses #8169

Closed dafeda closed 3 weeks ago

dafeda commented 3 weeks ago

[ ] PR title captures the intent of the changes, and is fitting for release notes.
[ ] Added appropriate release note label
[ ] Commit history is consistent and clean, in line with the contribution guidelines.
[ ] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[ ] Large PR: Prepare changes in small commits for more convenient review
[ ] Bug fix: Add regression test for the bug
[ ] Bug fix: Create Backport PR to latest release

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.58%. Comparing base (054d9aa) to head (c313ca5).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8169 +/- ## ======================================= Coverage 86.58% 86.58% ======================================= Files 384 384 Lines 23883 23883 Branches 636 621 -15 ======================================= + Hits 20679 20680 +1 + Misses 3131 3128 -3 - Partials 73 75 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.