equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

98 stars 104 forks source link

Add PROJECT_CODE to LSF and OpenPBS drivers when submitting a job #8175

Closed DanSava closed 5 days ago

DanSava commented 2 weeks ago

Issue Resolves #8048

(Screenshot of new behavior in GUI if applicable)

[ ] PR title captures the intent of the changes, and is fitting for release notes.
[ ] Added appropriate release note label
[ ] Commit history is consistent and clean, in line with the contribution guidelines.
[ ] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[ ] Large PR: Prepare changes in small commits for more convenient review
[ ] Bug fix: Add regression test for the bug
[ ] Bug fix: Create Backport PR to latest release

berland commented 2 weeks ago

Can you add the string "PROJECT_CODE" in some way in the commit message?

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.89%. Comparing base (f9dc451) to head (78f47b7). Report is 10 commits behind head on main.

Files	Patch %	Lines
src/ert/scheduler/__init__.py	80.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8175 +/- ## ========================================== - Coverage 87.02% 86.89% -0.14% ========================================== Files 378 375 -3 Lines 23952 23576 -376 Branches 632 626 -6 ========================================== - Hits 20844 20486 -358 + Misses 3027 3009 -18 Partials 81 81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

berland commented 6 days ago

It is maybe possible to also write integration tests for this, f.ex. if this project code leaves the project code string in an environment variable. Not sure if writing such a test should be prioritized.

8273 has the infrastructure for testing on environment variables.