Fix restart for ensemble experiment

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

98 stars 104 forks source link

Fix restart for ensemble experiment #8234

Closed frode-aarstad closed 1 day ago

frode-aarstad commented 1 week ago

Issue Resolves

Approach Short description of the approach

(Screenshot of new behavior in GUI if applicable)

[ ] PR title captures the intent of the changes, and is fitting for release notes.
[ ] Added appropriate release note label
[ ] Commit history is consistent and clean, in line with the contribution guidelines.
[ ] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[ ] Large PR: Prepare changes in small commits for more convenient review
[ ] Bug fix: Add regression test for the bug
[ ] Bug fix: Create Backport PR to latest release

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.86%. Comparing base (7281a93) to head (90f0ad7). Report is 3 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8234 +/- ## ======================================= Coverage 86.86% 86.86% ======================================= Files 379 379 Lines 23971 23976 +5 Branches 620 630 +10 ======================================= + Hits 20822 20827 +5 - Misses 3068 3075 +7 + Partials 81 74 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dafeda commented 5 days ago

As far as I can tell, this does not fix the problem described in #8032 . Or am I missing something?

frode-aarstad commented 5 days ago

As far as I can tell, this does not fix the problem described in #8032 . Or am I missing something?

If the problem you are referring to is that you want the successful reals to also show up after you do a restart, I am not sure that is even possible to do without major refactoring

dafeda commented 5 days ago

As far as I can tell, this does not fix the problem described in #8032 . Or am I missing something?

If the problem you are referring to is that you want the successful reals to also show up after you do a restart, I am not sure that is even possible to do without major refactoring

That is what issue #8032 describes I guess, so I was checking whether this PR solves that. Which part does this PR solve?

frode-aarstad commented 2 days ago

As far as I can tell, this does not fix the problem described in #8032 . Or am I missing something?

If the problem you are referring to is that you want the successful reals to also show up after you do a restart, I am not sure that is even possible to do without major refactoring

That is what issue #8032 describes I guess, so I was checking whether this PR solves that. Which part does this PR solve?

It solves a bug that corrupts the active realizations selected after the second restart. It also makes each restart run in the same ensemble/experiment. Perhaps I can detatch this PR from the issue and put the parent issue back in todo

dafeda commented 1 day ago

As far as I can tell, this does not fix the problem described in #8032 . Or am I missing something?

If the problem you are referring to is that you want the successful reals to also show up after you do a restart, I am not sure that is even possible to do without major refactoring

That is what issue #8032 describes I guess, so I was checking whether this PR solves that. Which part does this PR solve?

It solves a bug that corrupts the active realizations selected after the second restart. It also makes each restart run in the same ensemble/experiment. Perhaps I can detatch this PR from the issue and put the parent issue back in todo

I think that makes sense as the other issue is still unsolved and I think we do want it solved eventually.