equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
101 stars 104 forks source link

Fix bug in LSF driver resource manipulation #8256

Closed berland closed 3 months ago

berland commented 3 months ago

If both select and rusage was part of the existing resource string, and some hosts were attempted excluded, the previous code would inject the exclusion string at the wrong spot, failing to locate the correct end of the select statement.

Added tests that triggers the original bug.

Issue Resolves #8255

Approach Use regexp parsing

When applicable

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.85%. Comparing base (2ce2080) to head (20cc3ed). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8256 +/- ## ========================================== - Coverage 86.86% 86.85% -0.01% ========================================== Files 378 378 Lines 23946 23945 -1 Branches 631 636 +5 ========================================== - Hits 20800 20798 -2 - Misses 3067 3074 +7 + Partials 79 73 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.