Update pre-commits, and add more ruff rules

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

101 stars 104 forks source link

Update pre-commits, and add more ruff rules #8259

Closed larsevj closed 3 months ago

larsevj commented 3 months ago

[x] PR title captures the intent of the changes, and is fitting for release notes.
[x] Added appropriate release note label
[x] Commit history is consistent and clean, in line with the contribution guidelines.
[x] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[ ] Large PR: Prepare changes in small commits for more convenient review
[ ] Bug fix: Add regression test for the bug
[ ] Bug fix: Create Backport PR to latest release

larsevj commented 3 months ago

A bit unsure about the await asyncio.create_subprocess_shell and await asyncio.create_subprocess_exec( instead of Popen, ruff complains, however our usage of Popen is probably not blocking. So could ignore with comment or not include ruff rule.

The C4 rule changes are supposed to be faster, however readability might suffer? Calls to set(), dict(), tuple() now replaced with () and {}.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.01%. Comparing base (2193e75) to head (627d619). Report is 12 commits behind head on main.

Files	Patch %	Lines
src/ert/libres_facade.py	0.00%	1 Missing :warning:
src/ert/scheduler/__init__.py	66.66%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8259 +/- ## ========================================== + Coverage 86.85% 87.01% +0.15% ========================================== Files 378 378 Lines 23947 23952 +5 Branches 618 633 +15 ========================================== + Hits 20800 20842 +42 + Misses 3066 3037 -29 + Partials 81 73 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

berland commented 3 months ago

The second commit has an effectively void commit message..

larsevj commented 3 months ago

The second commit has an effectively void commit message..

Planned on squashing them all in the end.