equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
101 stars 104 forks source link

Mitigate flakyness in test_slurm_driver #8262

Closed berland closed 3 months ago

berland commented 3 months ago

The flakyness was easily reproducible with --count=100 -n 16, but after adding reruns the flakyness cannot be reproduced, so assuming reruns is sufficient (this was with mocked Slurm system, not with the --slurm option to pytest).

Since we have added reruns, we can reduce the job_kill_window when doing real integration tests also.

Issue Resolves #8260

Approach pytest.mark.flaky(reruns=3)

When applicable

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.04%. Comparing base (b3b5950) to head (91ad6e2). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8262 +/- ## ========================================== + Coverage 87.02% 87.04% +0.02% ========================================== Files 378 378 Lines 23947 23952 +5 Branches 624 618 -6 ========================================== + Hits 20840 20850 +10 + Misses 3029 3021 -8 - Partials 78 81 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.