Make sure adaptive localization works with single observation

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

98 stars 104 forks source link

Make sure adaptive localization works with single observation #8268

Closed dafeda closed 1 day ago

dafeda commented 2 days ago

Issue Resolves #8251

[ ] PR title captures the intent of the changes, and is fitting for release notes.
[ ] Added appropriate release note label
[ ] Commit history is consistent and clean, in line with the contribution guidelines.
[ ] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[ ] Large PR: Prepare changes in small commits for more convenient review
[ ] Bug fix: Add regression test for the bug
[ ] Bug fix: Create Backport PR to latest release

codecov-commenter commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.02%. Comparing base (3838267) to head (799c475).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8268 +/- ## ======================================= Coverage 87.02% 87.02% ======================================= Files 378 378 Lines 23954 23954 Branches 622 630 +8 ======================================= Hits 20846 20846 - Misses 3033 3034 +1 + Partials 75 74 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

berland commented 2 days ago

I will claim that "adloc" is squad language (or only local to the Feda?).. Not optimal for PR/commit message.

dafeda commented 1 day ago

I will claim that "adloc" is squad language (or only local to the Feda?).. Not optimal for PR/commit message.

True, I'll update the commit message.