Remove exception and error message statefullness from run models

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

103 stars 107 forks source link

Remove exception and error message statefullness from run models #8375

Closed oyvindeide closed 2 months ago

oyvindeide commented 3 months ago

Issue Resolves #my_issue

Approach Short description of the approach

(Screenshot of new behavior in GUI if applicable)

[x] PR title captures the intent of the changes, and is fitting for release notes.
[x] Added appropriate release note label
[x] Commit history is consistent and clean, in line with the contribution guidelines.
[x] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[ ] Large PR: Prepare changes in small commits for more convenient review
[ ] Bug fix: Add regression test for the bug
[ ] Bug fix: Create Backport PR to latest release

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.87%. Comparing base (50a9869) to head (463a773). Report is 2 commits behind head on main.

Files	Patch %	Lines
src/ert/run_models/base_run_model.py	93.75%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8375 +/- ## ========================================== - Coverage 90.88% 90.87% -0.01% ========================================== Files 347 347 Lines 21076 21064 -12 ========================================== - Hits 19154 19142 -12 Misses 1922 1922 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.