equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
103 stars 107 forks source link

Remove translation between JobState and JobStatus #8389

Closed jonathan-eq closed 2 months ago

jonathan-eq commented 2 months ago

This commit removes the legacy class for jobstatus, and instead replaces its use with JobState.

Issue Resolves #8342

Approach ✂️

(Screenshot of new behavior in GUI if applicable)

When applicable

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.65%. Comparing base (17e01cc) to head (d6e0a2a). Report is 42 commits behind head on main.

Files Patch % Lines
src/ert/simulator/batch_simulator_context.py 88.88% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8389 +/- ## ========================================== - Coverage 90.88% 90.65% -0.23% ========================================== Files 347 344 -3 Lines 21131 20989 -142 ========================================== - Hits 19204 19028 -176 - Misses 1927 1961 +34 ``` | [Flag](https://app.codecov.io/gh/equinor/ert/pull/8389/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | Coverage Δ | | |---|---|---| | [gui-tests](https://app.codecov.io/gh/equinor/ert/pull/8389/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `75.92% <83.67%> (-0.25%)` | :arrow_down: | | [integration-tests](https://app.codecov.io/gh/equinor/ert/pull/8389/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `53.93% <89.79%> (-0.33%)` | :arrow_down: | | [unit-tests](https://app.codecov.io/gh/equinor/ert/pull/8389/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `68.67% <93.87%> (-0.28%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.