Fix flaky test test_memory_profile_in_running_events

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

101 stars 104 forks source link

Fix flaky test test_memory_profile_in_running_events #8394

Closed jonathan-eq closed 1 month ago

jonathan-eq commented 1 month ago

Issue Resolves #8368

Approach This improves the observed flakiness by discarding more of the initial memory readings.

(Screenshot of new behavior in GUI if applicable)

[x] PR title captures the intent of the changes, and is fitting for release notes.
[x] Added appropriate release note label
[x] Commit history is consistent and clean, in line with the contribution guidelines.
[x] Make sure tests pass locally (after every commit!)

When applicable

[ ] When there are user facing changes: Updated documentation
[ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
[ ] Large PR: Prepare changes in small commits for more convenient review
[ ] Bug fix: Add regression test for the bug
[ ] Bug fix: Create Backport PR to latest release

berland commented 1 month ago

Is the length of the array always much longer than 7+7 (I don't remember..).

jonathan-eq commented 1 month ago

Is the length of the array always much longer than 7+7 (I don't remember..).

I assume so. I did a few test runs locally, and there it was always 30+.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.88%. Comparing base (840f483) to head (c6c129e).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8394 +/- ## ========================================== - Coverage 90.90% 90.88% -0.02% ========================================== Files 347 347 Lines 21068 21068 ========================================== - Hits 19151 19147 -4 - Misses 1917 1921 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.