Closed jonathan-eq closed 2 months ago
Attention: Patch coverage is 61.90476%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 90.62%. Comparing base (
24d9d2d
) to head (3b954e8
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/ert/gui/simulation/view/realization.py | 14.28% | 6 Missing :warning: |
src/ert/gui/model/snapshot.py | 60.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Think this looks like a good improvement! But dont think it solves the issue it is linked to? If there is an issue in the callback, that does not end up in the job error file, but is passed back as an event.
Think this looks like a good improvement! But dont think it solves the issue it is linked to? If there is an issue in the callback, that does not end up in the job error file, but is passed back as an event.
Oh, then I misunderstood the issue. Thanks for clarifying 👍
Think this looks like a good improvement! But dont think it solves the issue it is linked to? If there is an issue in the callback, that does not end up in the job error file, but is passed back as an event.
Oh, then I misunderstood the issue. Thanks for clarifying 👍
Yes, it should be https://github.com/equinor/ert/blob/6b7b21839ac89814da99e8e651b0271a3383e162/src/ert/scheduler/job.py#L248
It looks very good! Just not sure if there should be a test for callback_status_message
, maybe at least that the event contains data["callback_status_message"]
?
Issue Resolves #3578
Approach Short description of the approach
(Screenshot of new behavior in GUI if applicable)
When applicable