equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
103 stars 107 forks source link

Have GUI output callback error on realization hover #8398

Closed jonathan-eq closed 2 months ago

jonathan-eq commented 2 months ago

Issue Resolves #3578

Approach Short description of the approach

(Screenshot of new behavior in GUI if applicable) image

When applicable

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.62%. Comparing base (24d9d2d) to head (3b954e8). Report is 1 commits behind head on main.

Files Patch % Lines
src/ert/gui/simulation/view/realization.py 14.28% 6 Missing :warning:
src/ert/gui/model/snapshot.py 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8398 +/- ## ========================================== - Coverage 90.64% 90.62% -0.02% ========================================== Files 344 344 Lines 20970 20987 +17 ========================================== + Hits 19008 19020 +12 - Misses 1962 1967 +5 ``` | [Flag](https://app.codecov.io/gh/equinor/ert/pull/8398/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | Coverage Δ | | |---|---|---| | [gui-tests](https://app.codecov.io/gh/equinor/ert/pull/8398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `75.91% <57.14%> (-0.01%)` | :arrow_down: | | [integration-tests](https://app.codecov.io/gh/equinor/ert/pull/8398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `53.90% <52.38%> (+<0.01%)` | :arrow_up: | | [unit-tests](https://app.codecov.io/gh/equinor/ert/pull/8398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `68.61% <57.14%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oyvindeide commented 2 months ago

Think this looks like a good improvement! But dont think it solves the issue it is linked to? If there is an issue in the callback, that does not end up in the job error file, but is passed back as an event.

jonathan-eq commented 2 months ago

Think this looks like a good improvement! But dont think it solves the issue it is linked to? If there is an issue in the callback, that does not end up in the job error file, but is passed back as an event.

Oh, then I misunderstood the issue. Thanks for clarifying 👍

xjules commented 2 months ago

Think this looks like a good improvement! But dont think it solves the issue it is linked to? If there is an issue in the callback, that does not end up in the job error file, but is passed back as an event.

Oh, then I misunderstood the issue. Thanks for clarifying 👍

Yes, it should be https://github.com/equinor/ert/blob/6b7b21839ac89814da99e8e651b0271a3383e162/src/ert/scheduler/job.py#L248

jonathan-eq commented 2 months ago

image

xjules commented 2 months ago

It looks very good! Just not sure if there should be a test for callback_status_message, maybe at least that the event contains data["callback_status_message"]?