search

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
103 stars 107 forks source link

Dont use legacy parts of websockets #8573

Closed berland closed 1 month ago

berland commented 2 months ago

We are using legacy functionality from Websockets

https://github.com/equinor/ert/blob/86c523598d1100cb091bda1a498b5b31286fb1ce/src/ert/ensemble_evaluator/evaluator.py#L28

This will probably blow up at some point, so it should be fixed.

berland commented 1 month ago

PR #8585 was not sufficient to get rid of warning.

(python 3.11)

$ pytest tests/integration_tests/scheduler/test_openpbs_driver.py -sxv 
============================================================================================ warnings summary =============================================================================================
tests/integration_tests/scheduler/test_openpbs_driver.py::test_openpbs_driver_with_poly_example_failing_submit_fails_ert_and_propagates_exception_to_user
tests/integration_tests/scheduler/test_openpbs_driver.py::test_openpbs_driver_with_poly_example_failing_poll_fails_ert_and_propagates_exception_to_user
  /data/venv/311/lib64/python3.11/site-packages/websockets/legacy/server.py:1185: DeprecationWarning: remove second argument of ws_handler
    warnings.warn("remove second argument of ws_handler", DeprecationWarning)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================================================================================== 2 passed, 2 warnings in 4.62s ======================================================================================