Validate that DESIGN_MATRIX is correct upon initialization

equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).

https://ert.readthedocs.io/en/latest/

GNU General Public License v3.0

103 stars 107 forks source link

Validate that DESIGN_MATRIX is correct upon initialization #8686

Open xjules opened 2 months ago

xjules commented 2 months ago

The validation should include checking whether the design sheet part handles NUM_REALIZATIONS correctly, which means whether the all the design values combined with default sheet will handle the total number of realizations.

REAL column (if provided) should contain iens; which yield active realizations and thus filling the active realizations edit box.
in default sheet if the parameter is already present in the design sheet the default sheet entry is ignored otherwise it is appended as a new column with a singular default value.
make sure that the parameter names are unique

~~Blocked by: https://github.com/equinor/ert/issues/8902~~

larsevj commented 1 month ago

Currently design2params will fail if you run more realizations than entries in design matrix. Maybe we should do the same, just ignore NUM_REALIZATIONS if you choose design matrix and use number of realizations specified in the design matrix. For instance if you only specify realization 1,4,7 in the design matrix, than it is probably expected that only realizations 1,4,7 are actually run?

xjules commented 1 month ago

Currently design2params will fail if you run more realizations than entries in design matrix. Maybe we should do the same, just ignore NUM_REALIZATIONS if you choose design matrix and use number of realizations specified in the design matrix. For instance if you only specify realization 1,4,7 in the design matrix, than it is probably expected that only realizations 1,4,7 are actually run?

This makes sense for ensemble_experiment, but not sure if we are to use DESIGN_MATRIX in the update step. Let's focus only for the ensemble experiment for now. If we would choose a subset (active realizations) from the list of realizations in the design matrix, why would this not work?

larsevj commented 1 month ago

Some of the points of this issue has been covered but are still a lot of validation issues, some of them are:

Disallow spaces in parameter names
Decide if we will allow parameter names to be numbers or not
Handle empty input properly or misconfigured input, might rely on pandas for this. But maybe we should check what kind of error messages we receive and decide if we want to show these or display our own errors.
Find out what errors are dependent on each others and what are not, so that we can validate as much as possible before raising error?