equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
101 stars 104 forks source link

Use wait_for_child for getting RunDialog in test #8823

Closed eivindjahren closed 2 days ago

eivindjahren commented 2 days ago

Quick cleanup of comment and fetching of RunDialog in test_restart_ensemble

When applicable

codecov-commenter commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.38%. Comparing base (e607feb) to head (bb7f4be). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8823 +/- ## ========================================== + Coverage 91.31% 91.38% +0.06% ========================================== Files 342 342 Lines 21028 21028 ========================================== + Hits 19202 19216 +14 + Misses 1826 1812 -14 ``` | [Flag](https://app.codecov.io/gh/equinor/ert/pull/8823/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | Coverage Δ | | |---|---|---| | [cli-tests](https://app.codecov.io/gh/equinor/ert/pull/8823/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `39.62% <ø> (-0.02%)` | :arrow_down: | | [gui-tests](https://app.codecov.io/gh/equinor/ert/pull/8823/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `73.58% <ø> (+0.12%)` | :arrow_up: | | [performance-tests](https://app.codecov.io/gh/equinor/ert/pull/8823/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `50.05% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/equinor/ert/pull/8823/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `79.82% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.