equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
103 stars 107 forks source link

Use wait_for_child for getting RunDialog #8839

Closed eivindjahren closed 1 month ago

eivindjahren commented 1 month ago

Issue Simplifies for #8838

When applicable

eivindjahren commented 1 month ago

Does not solve flakyness, but valid as refactor.

Indeed, even failed on that commit, trying with increased timeout.

eivindjahren commented 1 month ago

Nope, times out also for 10s.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.39%. Comparing base (9f8d73a) to head (02f0ae4). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8839 +/- ## ========================================== + Coverage 91.37% 91.39% +0.01% ========================================== Files 342 342 Lines 21028 21028 ========================================== + Hits 19215 19218 +3 + Misses 1813 1810 -3 ``` | [Flag](https://app.codecov.io/gh/equinor/ert/pull/8839/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | Coverage Δ | | |---|---|---| | [cli-tests](https://app.codecov.io/gh/equinor/ert/pull/8839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `39.61% <ø> (+<0.01%)` | :arrow_up: | | [gui-tests](https://app.codecov.io/gh/equinor/ert/pull/8839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `73.58% <ø> (ø)` | | | [performance-tests](https://app.codecov.io/gh/equinor/ert/pull/8839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `50.05% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/equinor/ert/pull/8839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor) | `79.83% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=equinor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.