equinor / ert

ERT - Ensemble based Reservoir Tool - is designed for running ensembles of dynamical models such as reservoir models, in order to do sensitivity analysis and data assimilation. ERT supports data assimilation using the Ensemble Smoother (ES), Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and Iterative Ensemble Smoother (IES).
https://ert.readthedocs.io/en/latest/
GNU General Public License v3.0
103 stars 107 forks source link

Everest queue option `server` not working with LSF #9037

Open yngve-sk opened 1 day ago

yngve-sk commented 1 day ago

What happened? (You can include a screenshot if it helps explain)

The simulator.server option does not get mapped to a correct ErtConfig entry. It will only error if accompanied by queue_system: lsf

What did you expect to happen?

For it to get to the point of trying to submit the forward models to the queue, and failing if it does not exist.

steps to reproduce

How to recreate: Edit test-data/everest/math_func/config_multiobj.yml to have this simulator section:

simulator:
  queue_system: lsf
  cores: 3
  name: mr
  resubmit_limit: 17
  options: span = 1 && select[x86 and GNU/Linux]
  server: lx-fastserver01

Then run the test, see this:

        if errors:
>           raise ConfigValidationError.from_collected(errors)
E           ert.config.parsing.config_errors.ConfigValidationError: Invalid QUEUE_OPTION for LSF: 'LSF_SERVER'. Valid choices are ['BHIST_CMD', 'BJOBS_CMD', 'BKILL_CMD', 'BSUB_CMD', 'EXCLUDE_HOST', 'LSF_QUEUE', 'LSF_RESOURCE', 'MAX_RUNNING', 'PROJECT_CODE', 'SUBMIT_SLEEP'].

This was not triggered before because we did not always try to create an ErtConfig from the config dict, but will occur from trying to parse what should be a valid everest config into an ert config.

Environment where bug has been observed

larsevj commented 1 day ago

I believe this keyword was removed from ERT: https://github.com/equinor/ert/issues/8442 So should probably be removed from everest as well?