feat/vite storybook 7 - Githubissues

equinor / esv-intersection

A reusable component to create intersection visualizations for wells

https://equinor.github.io/esv-intersection/storybook/latest

MIT License

12 stars 7 forks source link

feat/vite storybook 7 #529

Closed ooystein closed 1 year ago

ooystein commented 1 year ago

Build with vite and esbuild
Update to storybook 7-beta (full release coming in march)
Use vite for building storybook

To simplify setup even further we should consider moving tests from jest to vitest. Then we can get rid of babel and jest configurations and dependencies. If vitest requires just as much configuration it might not be worth it, but if we can use vite for the tests and everything is configured the same it would make the whole setup much simpler to maintain.

ooystein commented 1 year ago

I have tested to link pacakge localy to compare the new build and it seems to work fine. But I encourage reviewers to test this PR against existing projects dependent on this library.

ovineq commented 1 year ago

I have tested to link pacakge localy to compare the new build and it seems to work fine. But I encourage reviewers to test this PR against existing projects dependent on this library.

Also tested linking these changes for our usage. Seems to work just fine 🎉

ooystein commented 1 year ago

Fixed review comments