search

equinor / everest

GNU General Public License v3.0
4 stars 5 forks source link

Make sure server and simulations are running on the same queue options #19

Closed DanSava closed 1 month ago

DanSava commented 1 month ago

Issue Closes #14

verveerpj commented 1 month ago

I think I may be missing something. Where in your changes is it enforced that server and simulation run on the same queue?

larsevj commented 1 month ago

Another question, which LSF queue would the jobs now use by default? "normal" or "mr" from ert-configurations?

DanSava commented 1 month ago

I think I may be missing something. Where in your changes is it enforced that server and simulation run on the same queue?

The title is a bit misleading I have updated it. The PR does not enforce that it uses the same key. It makes sure that the queue options between simulations and server are the same if they need to be.

DanSava commented 1 month ago

Another question, which LSF queue would the jobs now use by default? "normal" or "mr" from ert-configurations?

By default now both server and simulations will run on normal if no queue name is set in the everest config file simulator section.

larsevj commented 1 month ago

But why is this? Is it not desirable to use the settings from ert-configurations? Are there other settings from ert-configurations that we are not using then as well?

DanSava commented 1 month ago

But why is this? Is it not desirable to use the settings from ert-configurations? Are there other settings from ert-configurations that we are not using then as well?

We are using the settings from ert-configurations. What I am describing is the same behaviour that ert has if you define in an ert config file

        QUEUE_SYSTEM LSF
        QUEUE_OPTION LSF MAX_RUNNING  1

and not 

        QUEUE_SYSTEM LSF
        QUEUE_OPTION LSF LSF_QUEUE    (some queue name like `mr` or `normal` or `short`)
        QUEUE_OPTION LSF MAX_RUNNING  1
larsevj commented 1 month ago

Hm, but ert-configurations sets default LSF queue to "mr". So somehow everest is not extracting this, or unsetting this value? I f I understand correctly.

DanSava commented 1 month ago

Hm, but ert-configurations sets default LSF queue to "mr".

That is right but only if there are no other queue options set. If they are like a user added QUEUE_OPTION LSF MAX_RUNNING 1 and no LSF_QUEUE then default queue will be normal

In the case of everest sets for simulations QUEUE_OPTION LSF MAX_RUNNING 8 is set if no cores is part of the config by default. So if we want to have the same behaviour for the server we need to add QUEUE_OPTION LSF MAX_RUNNING 1 in the everest server ert config file.