search

equinor / flotilla

Flotilla is the main point of access for operators to interact with multiple robots in a facility.
Eclipse Public License 2.0
16 stars 37 forks source link

Missions that are started but cancelled is registered as ran in inspection plan #1063

Closed eivindsjovold closed 12 months ago

eivindsjovold commented 1 year ago

Describe the bug When a mission started from inspection plan is cancelled, it will register as completed in the inspection plan overview

To Reproduce Run missions in inspection plan, and cancel one that has ran a tag.

Expected behavior A bit unsure, might require discussion, but some system to log what tags are not run when mission is cancelled.

Screenshots If applicable, add screenshots to help explain your problem.

andchiind commented 1 year ago

The problem is that we use the LastRun value in the MissionDefinition model to check when it was last run, and currently we store any finished run, not just any successful run. To address this we could rename it to LastSuccessfulRun and check for the status of the completed mission, or we could store both LastRun and LastSuccessfulRun.

andchiind commented 1 year ago

This is now addressed in https://github.com/equinor/flotilla/pull/1041 by renaming lastRun to lastSuccessfulRun and only updating upon successful completion.