search

equinor / flotilla

Flotilla is the main point of access for operators to interact with multiple robots in a facility.
Eclipse Public License 2.0
16 stars 35 forks source link

Make a SecretService for backend #1306

Closed UsamaEquinorAFK closed 1 month ago

UsamaEquinorAFK commented 8 months ago

Describe the improvement you would like to see Add a new service for retrieving secrets from keyvault to reduce redundant code.

How will this change existing functionality? Will have one place where all secret fetching is handled, and less code in different services.

How will this improvement affect the current Threat Model? N/A - Feel free to add anything here if I missed something.

tsundvoll commented 8 months ago

Great name for a service

andchiind commented 8 months ago

I feel that the threat model could be affected, if we're not careful

UsamaEquinorAFK commented 8 months ago

I agree, as it says it's a proposed improvement. If there is something specific which anyone thinks should be considered we can look over that but as I understand we can't fetch secrets if we haven't completed az login step so we should be safe.

oysand commented 8 months ago

Check if it is possible to do well through the appsettings

aeshub commented 4 months ago

This issue has automatically been marked as stale as there has been no activity for 60 days.

Christdej commented 1 month ago

Appsettings is good enough