equinor / flotilla

Flotilla is the main point of access for operators to interact with multiple robots in a facility.
Eclipse Public License 2.0
16 stars 35 forks source link

Mixed use of plantCode and installationCode #1356

Closed Eddasol closed 7 months ago

Eddasol commented 8 months ago

Describe the improvement you would like to see Function is defined as GetAvailableMissions(string? installationCode) in echoService.cs, but is being used as echoService.GetAvailableMissions(plantCode) in echoContoller.cs. The argument should be installationCode both places.

Consider looking for mixed use elsewhere as well How will this change existing functionality?

How will this improvement affect the current Threat Model?

UsamaEquinorAFK commented 7 months ago

https://github.com/equinor/flotilla/pull/1391