search

equinor / flotilla

Flotilla is the main point of access for operators to interact with multiple robots in a facility.
Eclipse Public License 2.0
16 stars 38 forks source link

Move installation filtering of robots #1366

Closed Eddasol closed 9 months ago

Eddasol commented 9 months ago

Describe the improvement you would like to see Currently robots are filtered by installation several places in the frontend. As installationcode varies between lower letter and capital letter, the installationcode needs to be made lower letter before comparison in the filters. This needs to be remembered every time a installation filter is made.

Suggest moving the filtering to one place. Preferably to the backend.

How will this change existing functionality? Less prone to bugs and less repeated code

How will this improvement affect the current Threat Model?

UsamaEquinorAFK commented 9 months ago

Made it lower case upon access from database https://github.com/equinor/flotilla/pull/1390

UsamaEquinorAFK commented 9 months ago

Image

Works

UsamaEquinorAFK commented 9 months ago

Ended up using UPPERCASE everywhere