equinor / flotilla

Flotilla is the main point of access for operators to interact with multiple robots in a facility.
Eclipse Public License 2.0
16 stars 35 forks source link

Missions don't disappear from ongoing when they complete #1535

Closed Eddasol closed 4 months ago

Eddasol commented 5 months ago

Describe the bug Sometimes missions don't disappear from ongoing missions when they complete. They disappear on refresh indicating that the issue is only visual and caused by issues with signalR messages.

To Reproduce Have so far only been able to reproduce in aurora and not locally. To reproduce, schedule several short missons. Seems to happen more frequently if new missions are scheduled as one is completed.

Expected behavior Missions shouldn't be displayed in ongoing missions if its no longer ongoing

Screenshots image Several missions in ongoing even though HuldraBot is available and not running any of those missions anymore.

image Shreenshot of console when logging each time a signalR updated mission message is received. 4 messages are received within 1ms when the mission completes. Where status is ongoing in 2 of them and successful in the other two.

The bug is most likely caused by these messages sometimes being received in a different order such that the status gets overwritten to ongoing after a success status has been received.

Eddasol commented 4 months ago

1566 has solved this for the most common occurrence of this issue