search

equinor / flotilla

Flotilla is the main point of access for operators to interact with multiple robots in a facility.
Eclipse Public License 2.0
16 stars 36 forks source link

Backend crashes if we remove a mission from the queue that has just started #1548

Open mrica-equinor opened 2 months ago

mrica-equinor commented 2 months ago

Describe the bug If we click the remove mission from queue button just when the mission is starting, the status will be ongoing instead of pending but the ongoing card and pending mission card haven't re-rendered. As a consequence, the backend crashes.

This should not happen, the exception should be caught and a message to the frontend should say that the mission wasn't able to be removed because it already started. Possibly ask the user if it wants to stop the mission.

To Reproduce Remove the first mission in the queue just when the localization is finishing.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

tsundvoll commented 1 month ago

Seems like it would be OK to let the desired behaviour here be that the mission will start (it will not be removed / stopped) and then the operator would need to cancel the ongoing mission instead.

Implementation solution is to catch the exception and just move on