equinor / flotilla

Flotilla is the main point of access for operators to interact with multiple robots in a facility.
Eclipse Public License 2.0
16 stars 35 forks source link

Cannot handle tags that go over several decks #1567

Open Eddasol opened 5 months ago

Eddasol commented 5 months ago

Describe the bug For echo missions: Tags can only be registered for one area and if a tag goes over several decks it can cause issues.

Assume a tag tag1 that is on both deckA and deckB but is registered as being on deckA. If we want to inspect a part that is on deckB there will be issues. If tag1 is one of several tags (assuming normal tags on just one deck) then the mission will fail to be scheduled. If tag1 is the only one then the mission will be added to the inspection plan for deckA.

To Reproduce Schedule mission with tags that are registered as being on a different deck than the belonging robot/inspection pose

Expected behavior Should have a way to handle tags that spans more than one deck

Screenshots

Eddasol commented 5 months ago

Related to https://github.com/equinor/robotics-infrastructure/issues/482

andchiind commented 5 months ago

Could a solution be to remove line 288 in MissionSchedulingController, and instead just put a LogWarning?

Image

andchiind commented 5 months ago

I have made a PR which prevents an error being thrown when one or more tag is in a different deck, but this does not address the case where more tags are in a different deck/area than the one where we are actually running the mission on the robot. This is perhaps best solved within Echo, so I am moving this issue to blocked for now.

aeshub commented 3 months ago

This issue has automatically been marked as stale as there has been no activity for 60 days.