equinor / flotilla

Flotilla is the main point of access for operators to interact with multiple robots in a facility.
Eclipse Public License 2.0
16 stars 36 forks source link

Say failed to localize if canceling a mission #1657

Closed Eddasol closed 22 hours ago

Eddasol commented 1 week ago

Describe the bug When canceling a missions there becomes a banner saying "Failed localization mission".

There are two issues with this:

  1. As canceling doesn't have anything with localization to do (and the localization step was completed and successful), this is a misleading message and needs to be improved
  2. Canceling a mission shouldn't lead to a failure message as nothing actually failed, it was just purposely cancelled

How to reproduce

  1. Start a mission

  2. Cancel the mission (after the first step such that the localization should be good) Image

  3. Note banner popping up Image

mrica-equinor commented 4 days ago

This issue is a consequence of the issue below and should probably be closed https://github.com/orgs/equinor/projects/85?pane=issue&itemId=69123918

andchiind commented 22 hours ago

Closed as duplicate. See above comment