search

equinor / flotilla

Flotilla is the main point of access for operators to interact with multiple robots in a facility.
Eclipse Public License 2.0
16 stars 37 forks source link

Flotilla misses the first updates from ISAR #226

Closed aeshub closed 1 year ago

aeshub commented 2 years ago

Describe the bug Flotilla will as of #224 miss the initial updates to mission, task and step status because ISAR starts the mission and fires the first MQTT messages before Flotilla is finished writing the initial report to the database. This is because the mission starts before ISAR returns the mission details to Flotilla.

To Reproduce Start a mission in ISAR from Flotilla. Easiest seen using isar-robot as all updates will fail because it's so fast.

Expected behavior Flotilla should receive and react to all updates once a mission has started.

aeshub commented 2 years ago

Use a sleep for demo purposes as a workaround untill a proper fix can be put in place.

aeshub commented 2 years ago

Sleep has been put in place as a temporary solution to this issue. https://github.com/equinor/isar/commit/ce189ada782529ce75e2b5cd67ca6b58ee4b284e

aeshub commented 2 years ago

This issue has automatically been marked as stale as there has been no activity for 60 days. Remove stale label or comment or this will be closed in 7 days.

MortFred commented 2 years ago

Will be resolved by #274

aeshub commented 2 years ago

This issue has automatically been marked as stale as there has been no activity for 60 days. Remove stale label or comment or this will be closed in 7 days.

aeshub commented 1 year ago

This issue has automatically been marked as stale as there has been no activity for 60 days. Remove stale label or comment or this will be closed in 7 days.

Christdej commented 1 year ago

Remove workaround https://github.com/equinor/isar/commit/ce189ada782529ce75e2b5cd67ca6b58ee4b284e

MortFred commented 1 year ago

Bug is still there

aeshub commented 1 year ago

Did you try to remove this workaround @Christdej? As far as I can tell it is still there. Until further notice I will move this issue back to blocked.

Christdej commented 1 year ago

Did not test, just saw that in the comments Morten wrote that it would be resolved by #274 , but apparently it was not.

GodVenn commented 1 year ago

We believe this can be removed now, by removing the workaround which was added in https://github.com/equinor/isar/commit/ce189ada782529ce75e2b5cd67ca6b58ee4b284e

aeshub commented 1 year ago

Resolved by https://github.com/equinor/isar/pull/477