search

equinor / flotilla

Flotilla is the main point of access for operators to interact with multiple robots in a facility.
Eclipse Public License 2.0
16 stars 37 forks source link

Consider moving definition of ISAR api host and port #283

Closed anetteu closed 1 year ago

anetteu commented 2 years ago

Describe the improvement you would like to see Currently, flotilla overwrites the ISAR api host and port with the values provided by ISAR when an ISAR instance connecs and finds a robot in the flotilla database with the correct unique identifier. Consider letting flotilla keeping track of the hosts and ports instead, and let the ISAR instance update/overwrite its values on connect.

How will this change existing functionality? No change in functionality, just moving the responsibility of setting hosts and ports to flotilla who monitor several robots to easier ensure a unique port for each robot. Note that the possibility of setting host and port must not be removed from isar, but that it might be better that the values stored in flotilla overwrites the values in ISAR than the other way around.

How will this improvement affect the current Threat Model? No change.

aeshub commented 2 years ago

This issue has automatically been marked as stale as there has been no activity for 60 days. Remove stale label or comment or this will be closed in 7 days.

aeshub commented 1 year ago

This issue has automatically been marked as stale as there has been no activity for 60 days. Remove stale label or comment or this will be closed in 7 days.

aeshub commented 1 year ago

This issue has automatically been marked as stale as there has been no activity for 60 days. Remove stale label or comment or this will be closed in 7 days.

aeshub commented 1 year ago

This has already been implemented.