equinor / flotilla

Flotilla is the main point of access for operators to interact with multiple robots in a facility.
Eclipse Public License 2.0
16 stars 37 forks source link

Store error reasons for mission, task and step #871

Open aeshub opened 1 year ago

aeshub commented 1 year ago

Describe the new feature you would like to see After the implementation of https://github.com/equinor/isar/pull/457 ISAR will now include an error description with the MQTT messages that are sent when the status for a mission, task or step is updated. The MQTT message contains two fields

  1. ErrorDescription (This contains a log message with some detailed information about what went wrong)
  2. ErrorReason (This points to the type of exception which was raised in ISAR to cause this error)

Flotilla should

It might be that the ErrorDescription should just be stored on the mission while the ErrorReason is used as an error code which translates into a default message for that type of error. For example

Note that the frontend part of this issue is covered by #757

Describe the solution you'd like The end result of this issue should be that the information from ISAR messages are stored on the mission, task and step models such that #757 may implement the user facing error feedback.

How will this feature affect the current Threat Model?

andchiind commented 1 year ago

Storing this internal information on the database objects might mean that we need to create a new DTO for the mission controller endpoint, so that these errors are not exposed when retrieving missions with GET requests. We are currently returning the Mission data without any editing. Unless we want to assume that this is open information to anyone who can call the endpoints.

aeshub commented 1 year ago

This issue has automatically been marked as stale as there has been no activity for 60 days.

oysand commented 1 year ago

Issue completed

andchiind commented 1 year ago

It doesn't seem as if this issue has been completed, as the errors are not being received in Flotilla from Isar, so I'm reopening this

aeshub commented 11 months ago

This issue has automatically been marked as stale as there has been no activity for 60 days.

aeshub commented 6 months ago

This issue has automatically been marked as stale as there has been no activity for 60 days.

aeshub commented 1 month ago

This issue has automatically been marked as stale as there has been no activity for 60 days.