search

equinor / flotilla

Flotilla is the main point of access for operators to interact with multiple robots in a facility.
Eclipse Public License 2.0
16 stars 35 forks source link

Should use plantCode when fetching echo missions #876

Open Eddasol opened 1 year ago

Eddasol commented 1 year ago

Using installation code when fetching missions from echo gives a lot more missions than the once that are relevant. Will e.g. get missons from both Haugsneset and Johan Sverdrup when choosing either one of them. Same with Kårstø and Kalstø. See /api/plantInfo in https://echohubapi.equinor.com/.

Suggest getting echo to change parameter in endpoint "/api/robots/robot-plan" from installation code to plant code and implementing the same change on our side

andchiind commented 1 year ago

The necessary changes on our end have been implemented in #926 but the changes are not in Echo at the moment. The PR is shown as ready since the changes needed to fulfil this PR improves the code by making us store both the installation and plant code in the frontend, so it would be good to have in main. Only two lines need to be changed to make it request using PlantCode instead of InstallationCode (line 67 in MissionQueueView.tsx and line 36/37 in EchoService.cs)

aeshub commented 11 months ago

This issue has automatically been marked as stale as there has been no activity for 60 days.

aeshub commented 9 months ago

This issue has automatically been marked as stale as there has been no activity for 60 days.

tsundvoll commented 4 months ago

It is possible to amend the UI to make it display Installations instead of all the Plants

aeshub commented 2 months ago

This issue has automatically been marked as stale as there has been no activity for 60 days.