search

equinor / flownet

FlowNet - Data-Driven Reservoir Predictions
GNU General Public License v3.0
63 stars 29 forks source link

Default probability distributions #291

Closed olelod closed 3 years ago

olelod commented 3 years ago

In PR #251 all default probability distributions are set to uniform. Maybe some parameters should have a different default?

wouterjdb commented 3 years ago

This is in essence a breaking change as we had LOGUNIF(ORM) as default for at least the permeability but maybe also for things like the fault transmiscibility multiplier and maybe others?

I'm fine with the breaking change but we might need to update the Norne testdata file such that we still use what was intended.

olelod commented 3 years ago

The Norne testdata file is updated such that the parameters that had loguniform: true now have distribution: logunif. But permeability may have been set to loguniform inside the code (not in the config). Ill take a look at this ASAP.