equinor / flownet

FlowNet - Data-Driven Reservoir Predictions
GNU General Public License v3.0
63 stars 29 forks source link

I276 enabled new layering functionality #305

Closed LonnekevB closed 3 years ago

LonnekevB commented 3 years ago

Insert a description of your pull request (PR) here, and check off the boxes below when they are done.


Contributor checklist

LonnekevB commented 3 years ago

image The CI/CD now crashes on this. Don't really understand why it is even referring to a lambda function. Any ideas @wouterjdb ?

wouterjdb commented 3 years ago

The CI/CD now crashes on this. Don't really understand why it is even referring to a lambda function. Any ideas @wouterjdb ?

You are creating a collection called additional_flow_nodes and setting it to a value =2 one line later?

LonnekevB commented 3 years ago

You are creating a collection called additional_flow_nodes and setting it to a value =2 one line later?

But that was already there. The only thing I added is adding additional_flownodes to the _generate_connections():

starts, ends = _generate_connections( df_coordinates=DF_COORDINATES, configuration=config, additional_flownodes=config.flownet.additional_flow_nodes, )

wouterjdb commented 3 years ago

If the test actually runs fine you could consider ignoring the pylint warning: # pylint: disable=no-member.

wouterjdb commented 3 years ago

Also add an item in the CHANGELOG. 👍