equinor / flownet

FlowNet - Data-Driven Reservoir Predictions
GNU General Public License v3.0
63 stars 29 forks source link

Rename static (empty) SCHEDULE.inc file #332

Open edubarrosTNO opened 3 years ago

edubarrosTNO commented 3 years ago

Currently, for every FlowNet run, an empty file called SCHEDULE.inc is created. I think this file was originally intended to allow for a static file to be provided with prescribed VFP tables of the wells, but we have not used this yet (is it correct?). This file is later on included in the generated FLOWNET_REALIZATION.DATA files. Right now, it looks like if the static file is not provided (in the input_model folder from flownet-testdata), an empty file is generated. It is fine to keep it this way, but then I think that it should at least be renamed to avoid confusion (after all, this is not the schedule file; those are HISTORY_SCHEDULE.inc and PREDICTION_SCHEDULE.inc). Maybe something like VFP_TABLES.inc (if this was really the original intention)?

edubarrosTNO commented 3 years ago

I think this file is created here: _create_ert_setup.py, https://github.com/equinor/flownet/blob/master/src/flownet/ert/_create_ert_setup.py

for section in ["RUNSPEC", "PROPS", "SOLUTION", "SCHEDULE"]:
        static_source_path = pathlib.Path(static_path) / f"{section}.inc"
        if static_source_path.is_file():
            # If there is a static file for this section, for this field, copy it.
            shutil.copyfile(static_source_path, output_folder / f"{section}.inc")
        else:
            # Otherwise create an empty one.
            (output_folder / f"{section}.inc").touch()