equinor / flownet

FlowNet - Data-Driven Reservoir Predictions
GNU General Public License v3.0
63 stars 29 forks source link

Node placement in volume of original model #372

Closed LonnekevB closed 3 years ago

LonnekevB commented 3 years ago

Insert a description of your pull request (PR) here, and check off the boxes below when they are done.


Contributor checklist

edubarrosTNO commented 3 years ago

And for reference the real Norne model (initial pressure is quite off by the way, @edubarrosTNO I hope this is not the case in the cases you have been testing?):

I will have to check that, but what I can say now is that those cases that I have been running are certainly using much fewer additional nodes than what we see in these pictures.

Are there any current hypotheses for the initial pressure being off? To me it looks like the pressure is in the right range in most of the model, except for those red spots in one of the "tentacles". It would be useful to check the EQUIL regions of the full grid and FlowNet models, and see if there is any overlapping with the red spots in pressure in the FlowNet grid. If that is the case, we will have to revise the EQUIL settings of that region

LonnekevB commented 3 years ago

@wouterjdb I realized we were using convex and concave hull interchangeably in the Mitchells code. But for the grid cell bounding boxes it is a concave hull, but for the perforations, we actually use a convex hull. I think the naming is consistent now and once the tests have passed ready to merge!