equinor / flownet

FlowNet - Data-Driven Reservoir Predictions
GNU General Public License v3.0
66 stars 29 forks source link

Specifying rel_error and min_error in the config yaml #409

Closed olelod closed 3 years ago

olelod commented 3 years ago

Currently the flownet->data_source->simulation->input_case->vectors->XXXX has AllowNone for rel_errorand min_error. Both of them are required for generation of the .yamlobs and .ertobs file. No warnings or errors are issued if one of rel_errorand min_error is not specified, the observations for that vector is just dropped. If both are missing one get a not-a-dictionary error.

plgbrts commented 3 years ago

What would be the best? A: if not both (rel_error & min_error) are given, a warning should be provided with a message that the associated observation is dropped or B: if not both (rel_error & min_error) are given, an error should be given that the error specification is incomplete.

I assume B would be prefered but like to have a confirmation

olelod commented 3 years ago

I agree. B would be the preferred option (at this point, at least).