search

equinor / flyt

Equinor Flyt (aka. VSM - Value Stream Mapping)
https://flyt.equinor.com
MIT License
4 stars 1 forks source link

Fix TypeScript strict mode errors #668

Closed nesadrian closed 2 weeks ago

nesadrian commented 5 months ago

TypeScript strict mode should be set to true to improve the development process and code quality. Flyt was developed without strict mode and there is a lot of errors to fix.

HavardNot commented 3 weeks ago

ready for test in test.flyt.equinor.com @QiJin-Bouvet This is a non-functional change that affects almost all parts of the app. Will need a thorough regression test analysis to ensure nothing has been broken or changed for the worse.

QiJin-Bouvet commented 3 weeks ago

@HavardNot Tested in TEST env with commit 5cf774e. The PQIR cards turn grey when adding/removing a category to it. Refresh page fix it. This problem doesn't happen in QA env.

QiJin-Bouvet commented 3 weeks ago

Tested in Test env with commit be367ea PQIR cards are not grey when add/remove category on them.

nesadrian commented 2 weeks ago

@HavardNot @QiJin-Bouvet I think these changes has introduced a bug where the project menu scrim can't be closed. The bug exists on the main branch but not in QA, and these changes are the only ones that are not built to QA.

Image

QiJin-Bouvet commented 2 weeks ago

@HavardNot Could you take a look and make a fix for it?

HavardNot commented 2 weeks ago

ready for test in test.flyt.equinor.com @QiJin-Bouvet

QiJin-Bouvet commented 2 weeks ago

Tested with commit 17b9663 in TEST env. The menu works as expected.

QiJin-Bouvet commented 2 weeks ago

Tested in QA env. Works fine.