search

equinor / flyt

Equinor Flyt (aka. VSM - Value Stream Mapping)
https://flyt.equinor.com
MIT License
4 stars 1 forks source link

Choice cards should not be able to move to a node in its subtree #682

Closed nesadrian closed 4 months ago

nesadrian commented 4 months ago

Describe the bug Moving a choice card to a card that belongs to its subtree causes an error.

To Reproduce Steps to reproduce the behavior:

  1. Go to a process
  2. Add a new choice card
  3. Add a another choice card under one of this choices children.
  4. Move the first choice card on top of the second choice card.

Expected behavior All the cards that belongs to a choice cards subtree should be darkened and it should not be possible to drop it on top of any of them as this causes a loop in the hierarchy.

Cards that has children should also be disabled for choice movement since we don't have a way of merging these potentially complex relations.

nesadrian commented 4 months ago

@QiJin-Bouvet This is ready for test in POC DEV/QA

QiJin-Bouvet commented 4 months ago

Tested in qa-graph-poc. When dragging a choice card, those cards which don't accept the choice card turn to grey. image