Choice card disappear from UI in a loop case

equinor / flyt

Equinor Flyt (aka. VSM - Value Stream Mapping)

https://flyt.equinor.com

MIT License

4 stars 1 forks source link

Choice card disappear from UI in a loop case #688

Closed QiJin-Bouvet closed 5 months ago

QiJin-Bouvet commented 7 months ago

Tested in QA env. When there is a choice loop, after adding or deleting some sub-activity card, and then clicking on a choice card. Instead of the sidebar shown, the choice card disappear, (and the deleted card shown again). Refresh page can fix the problem and get correct result.

There are two scenarios to reproduce the problem. Console shows error like below:

QiJin-Bouvet commented 7 months ago

This issue has the same root cause as #687 Will test this card together when #687 is Done

QiJin-Bouvet commented 7 months ago

Tested in qa-graph-poc. Choice card disappear problem is not reproducible.

nesadrian commented 5 months ago

I noticed this error is still occuring in some special cases. When I tried to move the choice card in the screenshot I got this error because of the loop that I also have highlighted. This is process 3552 in POC DEV.

nesadrian commented 5 months ago

@QiJin-Bouvet Ready for test in poc dev

QiJin-Bouvet commented 5 months ago

@nesadrian Please double check the process number. Process 3552 in DEV doesn't show as the screenshot above.

QiJin-Bouvet commented 5 months ago

Tested with process 3767 (Duplicate of 3522) in POC DEV env. By moving the highlighted choice card:

no console error
no card disappear
all children nodes followed with correct structure

KaterynaBasik commented 5 months ago

Can we close this issue?

QiJin-Bouvet commented 5 months ago

I think so unless Adrian has more fix for it. What do you think? @nesadrian