Require content as input argument

[perolavsvendsen]

Currently, content is not a required input argument. It will default to depth if not given. Also, content is white-listed. This leads to pollution of the stored data in Sumo, where anything not currently present in the list becomes depth. In many cases, this is meaningless. At the same time, content is a key attribute for reading data. This will quickly lead to some very nasty patterns.

Example from a current implementation: RFT-data is exported with content: depth.

Possibly, we need also to look at the whitelisting of content. Is it feasible that we will cover all possible contents? Probably not, and this will lead to people exporting with wrong content.

Suggest to change white-list to list of "known" content, enforce rules on known content, but still allow other content.

[perolavsvendsen]

Suggested:

• [ ] Require content as input argument
• [ ] When content is in the white list, enforce current rules
• [ ] Allow content not in the white list, but issue warning

[perolavsvendsen]

This links to discussion around data products

[perolavsvendsen]

May need to still default content but then it should be to something clearly "wrong", e.g. "unknown" or "not-set" or something like that.

[perolavsvendsen]

Current state:

• content is optional, but missing content will trigger warning in .export()
• if content is not given as argument to .export(), it defaults to "unset"
• content is enumerated in the schema (whitelisting), and "unset" is not part of this list
• Hence, data objects where user has not set content, where fmu-dataio defaults to "unset", will not validate (and not be uploaded to Sumo).

Ref discussions with @tnatt - possibly time to enforce this more now?

• [ ] Require argument content (Breaking ⚠️)
• [ ] Remove all defaulting to "unset"