equinor / fmu-editor

5 stars 2 forks source link

Pass --no-sandbox and --deactivate-msal on Linux #79

Closed mferrera closed 1 year ago

mferrera commented 1 year ago

This PR updates electron-builder and adds a shell script shim when it builds Linux AppImages. The shell script is bundled in the AppImage and will automatically pass --no-sandbox to the app when opened normally, so it stays out of sight and mind.

Although electron-builder allows you to pass arguments automatically another way (see package.json -> build -> appImage -> executableArgs), this for some reason does not work with --no-sandbox. And incidentally, electron-builder actually passes this to it by default for AppImages, but it doesn't work! So a shim is required.

With respect to MSAL, it may be better to remove the electron version altogether and use the react version @azure/msal-react. This should accomplish the same thing but also work in a web version. But I haven't looked too deeply into it.