search

equinor / fmu-ensemble

Python objectification of reservoir model ensembles left on disk by ERT.
GNU General Public License v3.0
12 stars 19 forks source link

replace ecl2df with res2df #244

Closed asnyv closed 6 months ago

asnyv commented 9 months ago

closes #243

codecov-commenter commented 9 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 83.52%. Comparing base (ab3f4d7) to head (db7e5b6). Report is 1 commits behind head on master.

:exclamation: Current head db7e5b6 differs from pull request most recent head fb79ba9. Consider uploading reports for the commit fb79ba9 to get more accurate results

Files Patch % Lines
src/fmu/ensemble/realization.py 50.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #244 +/- ## ======================================= Coverage 83.52% 83.52% ======================================= Files 14 14 Lines 3072 3072 ======================================= Hits 2566 2566 Misses 506 506 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

asnyv commented 7 months ago

@eivindjahren @berland After thinking a bit more: This is technically a breaking change as the get_eclfiles function for ScratchRealization is replaced with get_resdatafiles. I doubt a lot of users use ScratchRealization directly, but should maybe have a deprecation period?

eivindjahren commented 7 months ago

@asnyv That seems reasonable. Maybe you can create an "alias" and then add a deprecation warning to it?

eivindjahren commented 6 months ago

This issue should be resolved now. Feel free to reopen the PR if it is not :) .