search

equinor / fmu-ensemble

Python objectification of reservoir model ensembles left on disk by ERT.
GNU General Public License v3.0
12 stars 19 forks source link

Align get_smry and load_smry #97

Open berland opened 4 years ago

berland commented 4 years ago

For a ScratchEnsemble, get_smry() and load_smry() may differ in dates returned - get_smry() first builds a list of dates to obtain data for, and then asks every realization for data at these dates, while load_smry() asks each realization independently. This will only happen if the realizations summary data have different end dates.

It is not given that this difference is a bug and not a feature, so perhaps it should only be documented.

berland commented 4 years ago

If behaviour should change, get_smry() should be changed to mimic load_smry().

berland commented 4 years ago

get_smry() can change behaviour towards load_smry() for a 2.0 release of fmu-ensemble. Bumping major revision because of this change in API.

berland commented 4 years ago

See also #94

berland commented 3 years ago

See also #180

berland commented 3 years ago

Solved in #182

berland commented 3 years ago

From proposed git commit:

Align load/get_smry, real-specific time index

ensemble.get_smr() will no longer ensure that the dates returned
are identical in all realization, realizations with shorter timespans
will not be extrapolated as they were before.

This also affects get_smry_stats(), for which realizations
which failed prematurely earlier had zero rates, affecting statistical
profiles. Now these realization with truncated time-series will only
affect the statistical profiles in the time-range they have data for.