equinor / fmu-sumo

Interaction with Sumo in the FMU context
https://fmu-sumo.readthedocs.io/en/latest/
Apache License 2.0
0 stars 5 forks source link

Enable filter on data.format #309

Closed perolavsvendsen closed 3 months ago

perolavsvendsen commented 3 months ago

Issue

304

Short description

_We may consider deprecating .format at some point, to avoid guiding people into overwriting built-in format.

This may work as a mitigation for https://github.com/equinor/fmu-dataio/pull/492. However, note:

An alternative would be to default to data.format="irap_binary" in the explorer, but this does not feel right.

Extra: Also improved testing of some other filters (assert that no results come back when filtering on non-existing value)

Pre-review checklist

Pre-merge checklist

perolavsvendsen commented 3 months ago

Don't know if this is the best way of solving this, inputs appreciated πŸ’¬

perolavsvendsen commented 3 months ago

For some reason I missed that the .format property was already there on the Child object. I will have another look at this to make sure things are consistent.

Edit: