equinor / fmu-tools

fmu-tools is a library containing tools for pre- and post-processing in a Fast Model Update (FMU) context
https://equinor.github.io/fmu-tools/
GNU Lesser General Public License v3.0
10 stars 14 forks source link

Add set_data_empty method to qc reset and edit init file #121

Closed JiZur closed 3 years ago

codecov-io commented 3 years ago

Codecov Report

Merging #121 (0e2eca0) into master (336c527) will decrease coverage by 2.08%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   79.21%   77.13%   -2.09%     
==========================================
  Files          29       29              
  Lines        2844     2921      +77     
==========================================
  Hits         2253     2253              
- Misses        591      668      +77     
Impacted Files Coverage Δ
src/fmu/tools/rms/qcreset.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 336c527...0e2eca0. Read the comment docs.

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging 98d79fdc998b37ef324a4f2233a7cae0728807b4 into 67a4724f5fbf62664a4ef839bc4e16499c65995c - view on LGTM.com

new alerts:

berland commented 3 years ago

Possible to add some tests?

JiZur commented 3 years ago

Problem is that it is meant to work only in RMS

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging 887b313343d546cd6eb930c97cfc58801f144341 into 67a4724f5fbf62664a4ef839bc4e16499c65995c - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging 35a775f0f9a97ca9d135f53fcebd7659956b0592 into 64cfba2159a9e9da6fc69d53eb87fed8a1df205e - view on LGTM.com

new alerts:

iainashepherd commented 3 years ago

Is testing needed for this? If so, can Jan's new approach for testing within RMS help the situation?

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts and fixes 1 when merging 0e2eca0540a91b6b8335cb792e266a8e1f590383 into 336c527a233faba726779787abec4e6128f9dc26 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts and fixes 1 when merging d195fc2d664feaf72d008edf412549767d7b57ff into 336c527a233faba726779787abec4e6128f9dc26 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert and fixes 1 when merging 22a435b1962f26196a69672bdba53a96e95a2003 into 70232980fa51458b08245bb2a7f92dd595db8469 - view on LGTM.com

new alerts:

fixed alerts:

JiZur commented 3 years ago

@HansKallekleiv : it now complains when building doc that _roxar is not defined in the last tests

codecov-commenter commented 3 years ago

Codecov Report

Merging #121 (e8f61f8) into master (336c527) will decrease coverage by 1.38%. The diff coverage is 66.07%.

:exclamation: Current head e8f61f8 differs from pull request most recent head cababa9. Consider uploading reports for the commit cababa9 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   79.21%   77.83%   -1.39%     
==========================================
  Files          29       30       +1     
  Lines        2844     2865      +21     
==========================================
- Hits         2253     2230      -23     
- Misses        591      635      +44     
Impacted Files Coverage Δ
src/fmu/tools/qcforward/_grid_quality.py 87.36% <ø> (-0.27%) :arrow_down:
src/fmu/tools/rms/qcreset.py 0.00% <0.00%> (ø)
src/fmu/tools/qcproperties/_config_parser.py 91.20% <91.20%> (ø)
src/fmu/tools/qcforward/_grid_statistics.py 91.34% <93.33%> (-0.88%) :arrow_down:
src/fmu/tools/qcproperties/qcproperties.py 96.73% <95.52%> (+18.08%) :arrow_up:
src/fmu/tools/qcproperties/_well2df.py 96.20% <96.20%> (ø)
src/fmu/tools/qcproperties/_grid2df.py 96.82% <96.82%> (ø)
src/fmu/tools/qcproperties/_aggregate_df.py 100.00% <100.00%> (ø)
src/fmu/tools/qcproperties/_utils.py 87.50% <100.00%> (+3.50%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 336c527...cababa9. Read the comment docs.

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert and fixes 1 when merging f02b3e7ad41108449c16ffc402c283fb69365fd1 into 70232980fa51458b08245bb2a7f92dd595db8469 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert and fixes 1 when merging b4af1c2870d395e69b10e154c85cfed7bf6f57fc into 70232980fa51458b08245bb2a7f92dd595db8469 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert and fixes 1 when merging 98758284981dfa8808113f2b205da55dbf67f0c8 into 70232980fa51458b08245bb2a7f92dd595db8469 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request fixes 1 alert when merging 6f046dde6e0d9d954024175bd05a3c8fdbd7cf68 into 70232980fa51458b08245bb2a7f92dd595db8469 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request fixes 1 alert when merging cababa94cda2ab575697d23ea3fbfc8c2a6bcded into 70232980fa51458b08245bb2a7f92dd595db8469 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request fixes 1 alert when merging 1de28a098f3e083d5d23c55515fd45bc66b8d237 into 70232980fa51458b08245bb2a7f92dd595db8469 - view on LGTM.com

fixed alerts: