Open odinr opened 1 year ago
we might be able to remove some code, since the package now provide:
getAccountByHomeId
getAccountByLocalId
getAccountByUsername
getActiveAccount
this was "hacked" together with:
check if there is a feature to replace:
Microsoft has rewritten the interface for MSAL 🥺
see changes for msal-browser@3, more than 2k files changed 😓
the "main" change is that after creating a
PublicClientApplication
, the instance need to await initializationProposed changes:
change logic from
JiT
to initialize clients in themodule.initialize
https://github.com/equinor/fusion-framework/blob/eb86f1e7ede7da1df1605d41601b702c9087879a/packages/modules/msal/src/module.ts#L19-L28
cause of error: https://github.com/equinor/fusion-framework/blob/eb86f1e7ede7da1df1605d41601b702c9087879a/packages/modules/msal/src/provider.ts#L70-L93 other:
see https://github.com/equinor/fusion-framework/pull/1167