equinor / fusion-react-components

mono repo for collection of react components used for Fusion apps
MIT License
7 stars 1 forks source link

Issue with hovering on custom tooltips #1148

Closed v3gard closed 5 months ago

v3gard commented 8 months ago

Describe the bug If custom tooltips are required, hovering doesn't work as expected as the "ease-out" fade transition on the hiding element fails to run.

A workaround is to add the following class style:

[class*="ag-tooltip-hiding"] {
        display: none;
    }

To Reproduce Steps to reproduce the behavior:

  1. Create an AG grid table
  2. Add a custom tooltip
  3. Add fusion styling
  4. See example here.

Expected behavior Ease-in and Ease-out transition works "out of the box", just in the official demos.

Screenshots Issue Workaround
aggrid_tooltip_issue aggrid_tooltip_workarond

Desktop (please complete the following information):

odinr commented 6 months ago

created a PR, will this fix your issue. Will this affect anyone not using custom tooltips (except fading out)?

can create a snapshot for testing if needed?

not to familiar with AG-Grid but can have @eikeland have a look

v3gard commented 6 months ago

Will this affect anyone not using custom tooltips (except fading out)?

Vet ikke. Jeg forstår ikke helt hvorfor vi må ha denne hack'en i utgangspunktet. Default AG grid oppfører seg ikke slik med custom tooltips.

can create a snapshot for testing if needed?

@odinr: Ja, takk. Tar gjerne en pakkereferanse som vi kan teste via npmjs

eikeland commented 6 months ago

@v3gard Do the issue persist when setting attribute tooltipHideDelay={0}?

odinr commented 6 months ago

created a snapshot @equinor/fusion-react-ag-grid-styles@issue-1148

v3gard commented 6 months ago

@eikeland @odinr It seems the issue is solved in the newest version of the involved packages, and that we can remove our local hack. I tested this using the CPR app with this package.json. I.e. the fade-out effect has started working (as it does in vanilla AG Grid without Fusion styling)

fixed-activities

image

This means that there's no need for the snapshot you created @odinr.

Can you also confirm this @AndreasPresthammer?

  1. We can remove our local hack.
  2. Custom tool tips still works (without the wonky UI error as initially described in this issue)

In that case, we can close this ticket.

AndreasPresthammer commented 6 months ago

@v3gard yes, it seem to work fine now 👌

odinr commented 6 months ago

@v3gard @AndreasPresthammer, so it works now without the css hack in https://github.com/equinor/fusion-react-components/pull/1325?

v3gard commented 5 months ago

@odinr Yes.