equinor / gatsby-developer-portal

https://developer.equinor.com
MIT License
2 stars 2 forks source link

add cookie consent banner #44

Closed cbuv closed 5 years ago

cbuv commented 5 years ago

What does this pull request change?

add initial cookie consent banner

Why is this pull request needed?

make user aware of cookie usages #48

What should be tested by reviewer?

Cookie banner is hidden after closing it in new pageviews. Didn't manage to test page in older browser, polyfill is available at window.sticky. css sticky have 90% coverage in all devices according to caniuse.

TODO:

Checklist

ingvald commented 5 years ago

hmm... vil me unngå gdpr-problematikk? (mao skru av cookies?)

cbuv commented 5 years ago

hmm... vil me unngå gdpr-problematikk? (mao skru av cookies?)

ja, vil sku av cookies for matamo, inntil brukeren samtykker (klikker på x). For andre cookies så må de slåes av.

ingvald commented 5 years ago

etter prat med Øyvind så trur eg me har signal på å starta utan cookies i det heile tatt.

dvs:

cbuv commented 5 years ago

lukker denne, ny pr med fjerning av socket io sin cookie.