equinor / iec63131

Other
8 stars 8 forks source link

Incorrect information about Opt and missing information for BlackBox in README.md #101

Closed Erik0x42 closed 1 month ago

Erik0x42 commented 2 months ago

In section 4.6 ElementaryFunctionLibrary the README.md states:

Some of the NorsokElementary functions can have n-number of input or output terminals. The AML-writer shall add additional terminals and use the same RefBaseClassPath as the existing terminals. Example:

  • Split and Opt: can have one input X and several output Y1, Y2, "Yn".
  • Or, XOR, AND, Add and Mul: can have several input X1, X2, "Xn" and one output Y.

Opt is placed incorrectly in first bullet item and must be moved to 2nd bullet item.

BlackBox (FunctionBlockLibrary/NonStandardFunctionBlockClass/BlackBox) is also missing coverage in the README and fits naturally when listing types and their output and input capabilities.
Propose to add BlackBox as third bullet item and define that it can have several inputs and outputs.