Change LegalValue "Substitute Value" of NorsokFunctionBlockClass attribute "InputTerminals.FallbackFunction" to "Fallback Value"

equinor / iec63131

Other

9 stars 8 forks source link

Change LegalValue "Substitute Value" of NorsokFunctionBlockClass attribute "InputTerminals.FallbackFunction" to "Fallback Value" #58

Closed AshokaK0 closed 1 year ago

AshokaK0 commented 2 years ago

Reference is made to the fourth LegalValue (Substitute Value) of NorsokFunctionBlockClass attribute "InputTerminals.FallbackFunction". 0: Last Valid 1: Min Range 2: Max Range 3: Substitute Value 4: Current Value

If the fourth LegalValue (Substitute Value) is intended to take value from attribute "InputTerminals.FallbackValue", then it is better to change "Substitute Value" to "Fallback Value".

AlexTxen commented 1 year ago

Discussions have been taken in the workshop held on 21.06.2023, refer to item 12. https://github.com/equinor/iec63131/blob/2c8fa87426e072459c5afc61afd97b1ce53cd28c/MOM%20AML%20Library%200.0.11%20workshop.docx

It has been agreed to change the wording from 'FallbackValue' to 'SubstituteValue'

AlexTxen commented 1 year ago

Implemented in aaa3ec2f0e674e4a40dabbe461146db5cb578f11 Issue can be closed.

Changed 'FallbackValue' attribute name to 'SubstituteValue':