equinor / iec63131

Other
9 stars 8 forks source link

Attributes with name 'Description' create potential conflict with built-in/omnipresent AML "Description" XML element #67

Open Erik0x42 opened 2 years ago

Erik0x42 commented 2 years ago

Every type in AML seems to support a Description, in AML Editor shown in the 'Header' tab, and in XML it is a simple XML element. A few types defined in the IEC 63131 AML Library have additional defined 'Description' as an attribute (in the 'Attribute' tab in the AML editor). This overloading seems like it should be avoided, and attributes should avoid names that are already declared in the 'Header' section.

Two possible solutions to avoid any overloading and uncertainty:

  1. Remove extra 'Description' attributes and move their respective text values to the Header's 'Description' (XML element), or
  2. Rename every 'Description' attribute to, eg, 'ServiceDescription'